Mark/msp_c2
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[Phase 1] Webhook System Implementation - Event Emission and Dispatcher #1

New issue
Closed
opened 2026-03-10 03:40:19 +00:00 by Mark · 13 comments
Mark commented 2026-03-10 03:40:19 +00:00
Owner
Copy link

Overview

The WebhookRegistry model exists in the database schema, but the actual webhook event emission system is not implemented. This is a high-priority Phase 1 feature.

Current State

  • ✅ Model: backend/models/webhook_registry.py exists
  • ❌ Event emission system
  • ❌ Webhook dispatcher
  • ❌ Retry logic
  • ❌ Delivery logs

Required Implementation

1. Event Emission System

Create event emitters for the following events (as defined in ROADMAP.md):

  • ticket.created
  • ticket.updated
  • ticket.status_changed
  • ticket.assigned
  • ticket.sla_breached
  • invoice.created
  • invoice.status_changed
  • user.created

2. Webhook Dispatcher

  • Async webhook dispatch (consider Celery)
  • Exponential backoff for retries
  • Webhook event queue (Redis)
  • Signature verification for security

3. API Endpoints

Implement the following endpoints:

  • POST /api/v1/hooks/register
  • GET /api/v1/hooks (list)
  • PATCH /api/v1/hooks/{id} (update)
  • DELETE /api/v1/hooks/{id}
  • POST /api/v1/hooks/{id}/test

4. Management UI

  • Webhook registration interface
  • Event type selection
  • Delivery logs viewer
  • Test webhook functionality

Technical Notes

  • Consider using Celery for async dispatch
  • Implement exponential backoff for retries
  • Add webhook event queue (Redis)
  • Ensure signature verification for security

Acceptance Criteria

  • All listed events emit webhooks correctly
  • Webhook dispatcher with retry logic
  • API endpoints for webhook CRUD operations
  • Frontend UI for webhook management
  • Delivery logs accessible
  • Signature verification implemented
  • Comprehensive tests added

Related Documents

  • docs/ROADMAP.md - Phase 1.1
  • backend/models/webhook_registry.py

Priority

🔥 HIGH

Effort Estimate

Medium (3-5 days)

## Overview The `WebhookRegistry` model exists in the database schema, but the actual webhook event emission system is not implemented. This is a high-priority Phase 1 feature. ## Current State - ✅ Model: `backend/models/webhook_registry.py` exists - ❌ Event emission system - ❌ Webhook dispatcher - ❌ Retry logic - ❌ Delivery logs ## Required Implementation ### 1. Event Emission System Create event emitters for the following events (as defined in ROADMAP.md): - `ticket.created` - `ticket.updated` - `ticket.status_changed` - `ticket.assigned` - `ticket.sla_breached` - `invoice.created` - `invoice.status_changed` - `user.created` ### 2. Webhook Dispatcher - Async webhook dispatch (consider Celery) - Exponential backoff for retries - Webhook event queue (Redis) - Signature verification for security ### 3. API Endpoints Implement the following endpoints: - `POST /api/v1/hooks/register` - `GET /api/v1/hooks` (list) - `PATCH /api/v1/hooks/{id}` (update) - `DELETE /api/v1/hooks/{id}` - `POST /api/v1/hooks/{id}/test` ### 4. Management UI - Webhook registration interface - Event type selection - Delivery logs viewer - Test webhook functionality ## Technical Notes - Consider using Celery for async dispatch - Implement exponential backoff for retries - Add webhook event queue (Redis) - Ensure signature verification for security ## Acceptance Criteria - [ ] All listed events emit webhooks correctly - [ ] Webhook dispatcher with retry logic - [ ] API endpoints for webhook CRUD operations - [ ] Frontend UI for webhook management - [ ] Delivery logs accessible - [ ] Signature verification implemented - [ ] Comprehensive tests added ## Related Documents - `docs/ROADMAP.md` - Phase 1.1 - `backend/models/webhook_registry.py` ## Priority 🔥 HIGH ## Effort Estimate Medium (3-5 days)
Mark commented 2026-05-27 21:47:26 +00:00
Author
Owner
Copy link

🤖 Claimed by gsd-issue-fixer-msp_c2-1 — starting work

🤖 Claimed by `gsd-issue-fixer-msp_c2-1` — starting work
Mark commented 2026-05-27 21:47:26 +00:00
Author
Owner
Copy link

🤖 Claimed by gsd-issue-fixer-msp_c2-1 — starting work

🤖 Claimed by `gsd-issue-fixer-msp_c2-1` — starting work
Mark commented 2026-05-27 21:47:26 +00:00
Author
Owner
Copy link

🤖 Claimed by gsd-issue-fixer-msp_c2-1 — starting work

🤖 Claimed by `gsd-issue-fixer-msp_c2-1` — starting work
Mark commented 2026-05-27 21:47:26 +00:00
Author
Owner
Copy link

🤖 Claimed by gsd-issue-fixer-msp_c2-1 — starting work

🤖 Claimed by `gsd-issue-fixer-msp_c2-1` — starting work
Mark commented 2026-05-27 21:47:26 +00:00
Author
Owner
Copy link

🤖 [gsd-issue-fixer-msp_c2-1] still working — claimed — starting pipeline

🤖 [`gsd-issue-fixer-msp_c2-1`] still working — claimed — starting pipeline
Mark commented 2026-05-27 21:47:26 +00:00
Author
Owner
Copy link

🤖 [gsd-issue-fixer-msp_c2-1] still working — claimed — starting pipeline

🤖 [`gsd-issue-fixer-msp_c2-1`] still working — claimed — starting pipeline
Mark commented 2026-05-27 21:47:26 +00:00
Author
Owner
Copy link

🤖 [gsd-issue-fixer-msp_c2-1] still working — claimed — starting pipeline

🤖 [`gsd-issue-fixer-msp_c2-1`] still working — claimed — starting pipeline
Mark commented 2026-05-27 21:47:26 +00:00
Author
Owner
Copy link

🤖 [gsd-issue-fixer-msp_c2-1] still working — claimed — starting pipeline

🤖 [`gsd-issue-fixer-msp_c2-1`] still working — claimed — starting pipeline
Mark commented 2026-05-27 21:47:26 +00:00
Author
Owner
Copy link

GSD pipeline blocked at RESEARCH: prerequisite gate (fetch) not passed.
Pipeline state needs reset. Check if another run is in progress.

GSD pipeline blocked at RESEARCH: prerequisite gate (fetch) not passed. Pipeline state needs reset. Check if another run is in progress.
Mark commented 2026-05-27 21:47:26 +00:00
Author
Owner
Copy link

GSD pipeline blocked at RESEARCH: prerequisite gate (fetch) not passed.
Pipeline state needs reset. Check if another run is in progress.

GSD pipeline blocked at RESEARCH: prerequisite gate (fetch) not passed. Pipeline state needs reset. Check if another run is in progress.
Mark commented 2026-05-27 21:47:26 +00:00
Author
Owner
Copy link

GSD pipeline blocked at RESEARCH: prerequisite gate (fetch) not passed.
Pipeline state needs reset. Check if another run is in progress.

GSD pipeline blocked at RESEARCH: prerequisite gate (fetch) not passed. Pipeline state needs reset. Check if another run is in progress.
Mark commented 2026-05-27 21:47:26 +00:00
Author
Owner
Copy link

GSD pipeline blocked at RESEARCH: prerequisite gate (fetch) not passed.
Pipeline state needs reset. Check if another run is in progress.

GSD pipeline blocked at RESEARCH: prerequisite gate (fetch) not passed. Pipeline state needs reset. Check if another run is in progress.
Mark 2026-06-08 09:45:56 +00:00
Mark commented 2026-08-11 02:49:58 +00:00
Author
Owner
Copy link

Note: the delivery engine for this issue (webhook_service.py / webhook_tasks.py / webhook_delivery_log.py) never landed in git — it exists only as untracked worktree files. Filed #44 to track. Docs claiming the webhook system is fully implemented are currently inaccurate for a fresh clone.

Note: the delivery engine for this issue (webhook_service.py / webhook_tasks.py / webhook_delivery_log.py) never landed in git — it exists only as untracked worktree files. Filed #44 to track. Docs claiming the webhook system is fully implemented are currently inaccurate for a fresh clone.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
No results found.
Labels
Clear labels   
blocked:gate-fetch

   
blocked:gate-fetch

   
blocked:gate-implement

   
blocked:gate-plan

   
blocked:needs-attention

   
blocked:needs-decision

   
blocked:needs-human

   
blocked:no-procedure

   
blocked:preflight

   
bug

Something is not working correctly

  
feature-request

   
in-progress

   
lint-cleanup

   
needs-decompose

Ready to be decomposed into sub-issues

  
needs-triage

   
ops-task

   
quickfix

   
security/medium

Medium severity security issue

  
triage-approved
No labels
blocked:gate-fetch
blocked:gate-fetch
blocked:gate-implement
blocked:gate-plan
blocked:needs-attention
blocked:needs-decision
blocked:needs-human
blocked:no-procedure
blocked:preflight
bug
feature-request
in-progress
lint-cleanup
needs-decompose
needs-triage
ops-task
quickfix
security/medium
triage-approved
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Mark/msp_c2#1
No description provided.