Mark/mc-heroes-mod

Fork 0

No equipment or item system #12

New issue

Closed

opened 2026-05-10 16:07:04 +00:00 by Mark · 3 comments

Mark commented

2026-05-10 16:07:04 +00:00

Owner

Description

No hero-specific items, weapons, or armor.

Impact

Cannot customize hero loadouts.

Suggested Fix

Add hero equipment with stat modifiers.

## Description No hero-specific items, weapons, or armor. ## Impact Cannot customize hero loadouts. ## Suggested Fix Add hero equipment with stat modifiers.

Mark added the

blocked:needs-decision

label

2026-05-12 23:26:23 +00:00

Mark commented

2026-05-13 21:56:46 +00:00

Author

Owner

Feature Triage Assessment

Scope: medium
Risk: low
Spec Alignment: misaligned
Summary: Wants to add hero-specific items, weapons, and armor with stat modifiers for customizable loadouts.
Recommendation: Misaligned with the project spec — the mod defines heroes as autonomous fake-player actors with fixed role/trait/weight systems, not RPG characters with gear. Reject or defer to a separate optional module. If pursued, implement as a new equipment package that modifies task score weights based on equipped items, keeping the core data model unchanged. Would add ~10-15 files (item registry, equipment slots on HeroActor, stat modifiers, NBT persistence, commands).
Rationale: SCOPE=medium: There is zero item/equipment infrastructure currently (no item registry, no inventory model, no stat modifiers on HeroActor). Adding this requires a new subsystem: item classes registered with NeoForge, equipment slots on the data model, stat modifiers affecting task scoring, NBT serialization for persistence, and admin commands. That's ~10-15 new/modified files — a complete new module. RISK=low: Item registration follows standard NeoForge patterns, and adding equipment is purely additive — it wouldn't touch existing task implementations, the scene FSM, the backend abstraction, or the spawn/despawn lifecycle. Stat modifiers could subtly affect task scoring but that's manageable. No IO, no security surface. SPEC=misaligned: The entire SPEC.md, plan.md, and README describe heroes as autonomous actors performing scenes (patching walls, lighting paths, fishing, camping). There is zero mention of items, weapons, armor, equipment, loadouts, or stat modifiers anywhere in the design documents. The role/trait/weight system already provides hero differentiation. This feature stretches the mod's core identity.

Labeled blocked:needs-decision — unblock on Forgejo to dispatch to the fixer pipeline.

## Feature Triage Assessment **Scope:** medium **Risk:** low **Spec Alignment:** misaligned **Summary:** Wants to add hero-specific items, weapons, and armor with stat modifiers for customizable loadouts. **Recommendation:** Misaligned with the project spec — the mod defines heroes as autonomous fake-player actors with fixed role/trait/weight systems, not RPG characters with gear. Reject or defer to a separate optional module. If pursued, implement as a new equipment package that modifies task score weights based on equipped items, keeping the core data model unchanged. Would add ~10-15 files (item registry, equipment slots on HeroActor, stat modifiers, NBT persistence, commands). **Rationale:** SCOPE=medium: There is zero item/equipment infrastructure currently (no item registry, no inventory model, no stat modifiers on HeroActor). Adding this requires a new subsystem: item classes registered with NeoForge, equipment slots on the data model, stat modifiers affecting task scoring, NBT serialization for persistence, and admin commands. That's ~10-15 new/modified files — a complete new module. RISK=low: Item registration follows standard NeoForge patterns, and adding equipment is purely additive — it wouldn't touch existing task implementations, the scene FSM, the backend abstraction, or the spawn/despawn lifecycle. Stat modifiers could subtly affect task scoring but that's manageable. No IO, no security surface. SPEC=misaligned: The entire SPEC.md, plan.md, and README describe heroes as autonomous actors performing scenes (patching walls, lighting paths, fishing, camping). There is zero mention of items, weapons, armor, equipment, loadouts, or stat modifiers anywhere in the design documents. The role/trait/weight system already provides hero differentiation. This feature stretches the mod's core identity. Labeled `blocked:needs-decision` — unblock on Forgejo to dispatch to the fixer pipeline.

Mark referenced this issue from a commit

2026-05-13 22:03:16 +00:00

Add equipment/inventory system section (issue #12)

Mark referenced this issue from a commit

2026-05-13 22:03:16 +00:00

Add Stage 10 — Equipment & Inventory System (issue #12)

Mark added

feature-request

triage-approved

and removed

blocked:needs-decision

labels

2026-05-13 22:03:38 +00:00

Mark commented

2026-05-13 22:04:04 +00:00

Author

Owner

Spec Updated & Approved

Decision: Accept — gear/inventory enables heroes to properly emulate real players (hold tools during tasks, wear armor, use items).

Changes made:

SPEC.md — Added Section 11 (Equipment & Inventory System):
- 6 equipment slots (MAINHAND, OFFHAND, HEAD, CHEST, LEGS, FEET)
- JSON datapack-based item definitions with per-task score multipliers
- Effects on execution speed, fatigue, and task scoring
- NBT persistence in HeroActor data
- ActorBackend integration — equipped items appear on the entity
- Commands: /heroes equip, /heroes unequip, /heroes inventory
plan.md — Added Stage 10 (Equipment & Inventory System)

Labels: Removed blocked:needs-decision, added triage-approved. Ready for the fixer pipeline.

## Spec Updated & Approved **Decision:** Accept — gear/inventory enables heroes to properly emulate real players (hold tools during tasks, wear armor, use items). **Changes made:** - **SPEC.md** — Added Section 11 (Equipment & Inventory System): - 6 equipment slots (MAINHAND, OFFHAND, HEAD, CHEST, LEGS, FEET) - JSON datapack-based item definitions with per-task score multipliers - Effects on execution speed, fatigue, and task scoring - NBT persistence in HeroActor data - ActorBackend integration — equipped items appear on the entity - Commands: /heroes equip, /heroes unequip, /heroes inventory - **plan.md** — Added Stage 10 (Equipment & Inventory System) **Labels:** Removed blocked:needs-decision, added triage-approved. Ready for the fixer pipeline.

Mark removed the

triage-approved

label

2026-05-13 22:04:17 +00:00

Mark added

blocked:needs-decision

and removed

feature-request

labels

2026-05-20 22:04:46 +00:00

Mark added

triage-approved