[OPTIMIZATION] Metrics Engine - Algorithmic Complexity - src/lib/metrics-engine.ts #63

New issue

Closed

opened 2026-06-06 20:47:35 +00:00 by Mark · 0 comments

Mark commented

2026-06-06 20:47:35 +00:00

Owner

Critical Issues (2)

.sort()[0] for max element (4 locations: lines 567, 584, 652, 781)
- Fix: Use reduce for O(n) max instead of O(n log n) sort
- Impact: 10-50x faster for large arrays
Observation keyword scan: O(observations × interactions) with string ops
- Fix: Pre-index interactions by keywords/topics using Map
- Impact: 10-100x faster

Medium Issues (2)

Double sort: interactions.sort(desc) then [...].sort(asc)
- Fix: Reverse first sort instead: [...sorted].reverse()
- Impact: 2x faster sorting
Dead code: 6 functions only used in tests (computeAllPersonMetrics, computeCrossPersonMetrics, detectCycles, generateAllSuggestions, predictNextContact, predictAllNextContacts)
- Fix: Move to test files

## Critical Issues (2) 1. **`.sort()[0]` for max element** (4 locations: lines 567, 584, 652, 781) - Fix: Use `reduce` for O(n) max instead of O(n log n) sort - Impact: 10-50x faster for large arrays 2. **Observation keyword scan**: O(observations × interactions) with string ops - Fix: Pre-index interactions by keywords/topics using Map - Impact: 10-100x faster ## Medium Issues (2) 3. **Double sort**: `interactions.sort(desc)` then `[...].sort(asc)` - Fix: Reverse first sort instead: `[...sorted].reverse()` - Impact: 2x faster sorting 4. **Dead code**: 6 functions only used in tests (`computeAllPersonMetrics`, `computeCrossPersonMetrics`, `detectCycles`, `generateAllSuggestions`, `predictNextContact`, `predictAllNextContacts`) - Fix: Move to test files