[OPTIMIZATION] Native Communication Module - Timeouts & Retry - src/lib/native/communication.ts #61

New issue

Closed

opened 2026-06-06 20:46:02 +00:00 by Mark · 0 comments

Mark commented

2026-06-06 20:46:02 +00:00

Owner

Critical Issues (1)

Native calls without timeouts - CallLog.getCallLog(), Sms.getSms(), Email.getEmails() can hang indefinitely
- Fix: Wrap each with Promise.race + 5s timeout

High Issues (1)

Empty catch blocks swallow errors - no retry on transient failures
- Fix: 3-attempt exponential backoff before giving up

Medium Issues (1)

Bare catch { return false } masks programming bugs as "permission denied"
- Fix: Only catch expected errors (e.g., DOMException with SecurityError)

## Critical Issues (1) 1. **Native calls without timeouts** - `CallLog.getCallLog()`, `Sms.getSms()`, `Email.getEmails()` can hang indefinitely - Fix: Wrap each with `Promise.race` + 5s timeout ## High Issues (1) 2. **Empty catch blocks swallow errors** - no retry on transient failures - Fix: 3-attempt exponential backoff before giving up ## Medium Issues (1) 3. **Bare `catch { return false }`** masks programming bugs as "permission denied" - Fix: Only catch expected errors (e.g., `DOMException` with `SecurityError`)