[OPTIMIZATION] Settings Page - CSV/Contacts Import N+1 - src/pages/Settings.tsx #56

New issue

Closed

opened 2026-06-06 20:42:12 +00:00 by Mark · 0 comments

Mark commented

2026-06-06 20:42:12 +00:00

Owner

Critical Issues (2)

CSV import: for (const row of imported) { await addPerson(...) } - N+1 inserts
- Fix: Build array, use db.people.bulkAdd(contactsArray)
- Impact: 10-50x faster bulk import
Native contacts import: Same N+1 pattern in for (const contact of contactsToImport)
- Fix: Batch with bulkAdd in chunks of 50

High Issues (1)

Sequential native contact processing - batch with Promise.all chunks

Medium Issues (2)

Duplicate filter logic ×3 (call/sms/email previews) - extract shared useCallback
FileReader missing onerror handlers (2 instances) - add error rejection

Low Issues (1)

68 inline style={{}} objects - move to Tailwind classes

## Critical Issues (2) 1. **CSV import**: `for (const row of imported) { await addPerson(...) }` - N+1 inserts - Fix: Build array, use `db.people.bulkAdd(contactsArray)` - Impact: 10-50x faster bulk import 2. **Native contacts import**: Same N+1 pattern in `for (const contact of contactsToImport)` - Fix: Batch with `bulkAdd` in chunks of 50 ## High Issues (1) 3. **Sequential native contact processing** - batch with `Promise.all` chunks ## Medium Issues (2) 4. **Duplicate filter logic** ×3 (call/sms/email previews) - extract shared `useCallback` 5. **FileReader missing `onerror` handlers** (2 instances) - add error rejection ## Low Issues (1) 6. **68 inline `style={{}}` objects** - move to Tailwind classes