Mark/kimi_agent_hero_forge_slice_issue
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix Ref Mutations in EditorScene.tsx #6

New issue
Closed
opened 2026-06-06 21:06:19 +00:00 by Mark · 0 comments
Mark commented 2026-06-06 21:06:19 +00:00
Owner
Copy link

Direct mutation of gl.domElement.style.cursor and gl.localClippingEnabled violates React hooks immutability rules.

Files/Lines:

  • src/pages/editor/EditorScene.tsx:267 - gl.domElement.style.cursor = "grabbing"
  • src/pages/editor/EditorScene.tsx:305 - gl.domElement.style.cursor = "default"
  • src/pages/editor/EditorScene.tsx:371 - gl.domElement.style.cursor = "grab"
  • src/pages/editor/EditorScene.tsx:374 - gl.domElement.style.cursor = "default"
  • src/pages/editor/EditorScene.tsx:850 - gl.localClippingEnabled = true

Fix: Use refs for DOM mutations, or use useLayoutEffect with proper cleanup.

Direct mutation of `gl.domElement.style.cursor` and `gl.localClippingEnabled` violates React hooks immutability rules. **Files/Lines:** - `src/pages/editor/EditorScene.tsx:267` - `gl.domElement.style.cursor = "grabbing"` - `src/pages/editor/EditorScene.tsx:305` - `gl.domElement.style.cursor = "default"` - `src/pages/editor/EditorScene.tsx:371` - `gl.domElement.style.cursor = "grab"` - `src/pages/editor/EditorScene.tsx:374` - `gl.domElement.style.cursor = "default"` - `src/pages/editor/EditorScene.tsx:850` - `gl.localClippingEnabled = true` **Fix:** Use refs for DOM mutations, or use `useLayoutEffect` with proper cleanup.
Mark closed this issue 2026-06-14 09:28:42 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
No results found.
Labels
Clear labels   
blocked:needs-decision

   
bug

   
component:editor

   
component:hero

   
priority:p2

   
priority:p3

   
priority:p4

   
quickfix

Small scoped fix for quick pipeline

  
test-coverage

Test coverage review / gap report

  
triage-approved

Approved by triage

  
type:bug

   
type:enhancement
No labels
blocked:needs-decision
bug
component:editor
component:hero
priority:p2
priority:p3
priority:p4
quickfix
test-coverage
triage-approved
type:bug
type:enhancement
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Mark/kimi_agent_hero_forge_slice_issue#6
No description provided.