Fix Conditional React Hooks in EditorScene.tsx #3
Labels
No labels
blocked:needs-decision
bug
component:editor
component:hero
priority:p2
priority:p3
priority:p4
quickfix
test-coverage
triage-approved
type:bug
type:enhancement
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Mark/kimi_agent_hero_forge_slice_issue#3
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Multiple React hooks (
useCallback,useMemo,useEffect,useFrame) are called conditionally after early returns, violating Rules of Hooks.Files/Lines:
src/pages/editor/EditorScene.tsx:143-useCallbackinTransformGizmosrc/pages/editor/EditorScene.tsx:271-useCallbackinSlicePlaneVisualsrc/pages/editor/EditorScene.tsx:300-useCallbackinSlicePlaneVisualsrc/pages/editor/EditorScene.tsx:305-useEffectinSlicePlaneVisualsrc/pages/editor/EditorScene.tsx:317-useMemoinSlicePlaneVisualsrc/pages/editor/EditorScene.tsx:339-useMemoinSlicePlaneVisualsrc/pages/editor/EditorScene.tsx:508-useCallbackinBoneVisuals(afterif (!showSkeleton) return null;)src/pages/editor/EditorScene.tsx:642-useFrameinJointDetectionRings(afterif (activeTool !== "joint") return null;)Fix: Move all hooks to the top of component functions, before any early returns. Use conditional logic inside hooks or render JSX conditionally instead.