CI workflow missing actual test execution #2

New issue

Closed

opened 2026-05-14 04:47:39 +00:00 by Mark · 2 comments

Mark commented

2026-05-14 04:47:39 +00:00

Owner

The current .forgejo/workflows/ci.yml only builds the Docker image, runs flake8, and validates docker-compose. It does not:

Run the Python test suite (blocked by Issue #1)
Verify the Docker image can actually start Xvfb + openbox + noVNC
Test any of the deployment adapters
Run a smoke test (e.g. launch a simple X11 app and take a screenshot)

Once tests exist, add a CI step that runs pytest inside the built container or a dev container.

Why: Build-pass does not guarantee runtime functionality. A broken supervisord config or missing X11 dependency would go unnoticed.

The current `.forgejo/workflows/ci.yml` only builds the Docker image, runs flake8, and validates docker-compose. It does not: 1. Run the Python test suite (blocked by Issue #1) 2. Verify the Docker image can actually start Xvfb + openbox + noVNC 3. Test any of the deployment adapters 4. Run a smoke test (e.g. launch a simple X11 app and take a screenshot) Once tests exist, add a CI step that runs `pytest` inside the built container or a dev container. **Why:** Build-pass does not guarantee runtime functionality. A broken supervisord config or missing X11 dependency would go unnoticed.