MODERATE: Renderer.js rendering methods never called from main.js #5
Labels
No labels
blocked:needs-decision
blocked:no-changes
feature-request
quickfix
test-coverage
triage-approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Mark/gravity-racer#5
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Description
Renderer.js defines several rendering methods that are never called. Instead, main.js has its own inline rendering implementations.
Unused Renderer methods
renderBackground()renderGravityWells()renderCheckpoints()renderSpinLaunchers()renderJumpPoints()renderTrajectory()present()applyCamera()/restoreCamera()Duplicate implementations in main.js
_drawWell()_drawCheckpoint()_drawSpinLauncher()_drawJumpPoint()_drawTrajectory()_renderStarfield()Fix
Choose one approach: either call Renderer's methods from main.js, or inline all rendering in main.js. Having both causes maintenance issues and confusion.