MODERATE: Renderer.js rendering methods never called from main.js #5

Closed
opened 2026-05-11 06:16:42 +00:00 by Mark · 0 comments
Owner

Description

Renderer.js defines several rendering methods that are never called. Instead, main.js has its own inline rendering implementations.

Unused Renderer methods

  • renderBackground()
  • renderGravityWells()
  • renderCheckpoints()
  • renderSpinLaunchers()
  • renderJumpPoints()
  • renderTrajectory()
  • present()
  • applyCamera() / restoreCamera()

Duplicate implementations in main.js

  • _drawWell()
  • _drawCheckpoint()
  • _drawSpinLauncher()
  • _drawJumpPoint()
  • _drawTrajectory()
  • _renderStarfield()

Fix

Choose one approach: either call Renderer's methods from main.js, or inline all rendering in main.js. Having both causes maintenance issues and confusion.

## Description Renderer.js defines several rendering methods that are never called. Instead, main.js has its own inline rendering implementations. ## Unused Renderer methods - `renderBackground()` - `renderGravityWells()` - `renderCheckpoints()` - `renderSpinLaunchers()` - `renderJumpPoints()` - `renderTrajectory()` - `present()` - `applyCamera()` / `restoreCamera()` ## Duplicate implementations in main.js - `_drawWell()` - `_drawCheckpoint()` - `_drawSpinLauncher()` - `_drawJumpPoint()` - `_drawTrajectory()` - `_renderStarfield()` ## Fix Choose one approach: either call Renderer's methods from main.js, or inline all rendering in main.js. Having both causes maintenance issues and confusion.
Mark closed this issue 2026-05-11 18:18:23 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Mark/gravity-racer#5
No description provided.