Mark/freshfind-marketmap

Fork 0

[smoke-test] Test coverage review: 17 source files, 2 test files (11.8%) #8

New issue

Closed

opened 2026-05-16 11:28:09 +00:00 by Mark · 4 comments

Mark commented

2026-05-16 11:28:09 +00:00

Owner

Smoke Test Review: Mark/freshfind-marketmap

Type: node | Runtime: node
Source files: 17 | Test files: 2 | Coverage: 11.8%

Observations

Frontend: 13 component files in src/
No dedicated test directory found

Risks

⚠️ Low test coverage: 11.8% of source files have tests

Recommendations

Increase test coverage to at least 50%

Auto-filed by project-smoke-test.py on 2026-05-16 11:28:09 UTC

## Smoke Test Review: Mark/freshfind-marketmap **Type:** node | **Runtime:** node **Source files:** 17 | **Test files:** 2 | **Coverage:** 11.8% ### Observations - Frontend: 13 component files in src/ - No dedicated test directory found ### Risks - ⚠️ Low test coverage: 11.8% of source files have tests ### Recommendations - Increase test coverage to at least 50% --- _Auto-filed by project-smoke-test.py on 2026-05-16 11:28:09 UTC_

Mark added the

blocked:needs-human

label

2026-05-17 22:57:43 +00:00

Mark commented

2026-05-18 02:44:45 +00:00

Author

Owner

GSD VERIFY phase found no changes after implementation.
Worker output: ┊ review diff
a//home/b/Projects/freshfind-marketmap/src/components/Navigation.test.tsx → b//home/b/Projects/freshfind-marketmap/src/components/Navigation.test.tsx
@@ -42,7 +42,7 @@
it("starts with transparent background when not scrolled", () => {
render();
const na

GSD VERIFY phase found no changes after implementation. Worker output: ┊ review diff a//home/b/Projects/freshfind-marketmap/src/components/Navigation.test.tsx → b//home/b/Projects/freshfind-marketmap/src/components/Navigation.test.tsx @@ -42,7 +42,7 @@ it("starts with transparent background when not scrolled", () => { render(<Navigation />); const na

Mark added

triage-approved

and removed

blocked:needs-human

labels

2026-05-23 16:46:35 +00:00

Mark added

blocked:needs-human

and removed

triage-approved

labels

2026-05-27 02:38:03 +00:00

Mark commented

2026-05-27 02:38:03 +00:00

Author

Owner

GSD VERIFY phase found no changes after implementation.
Worker output: ]11;?\[0m[?7h[0m ┊ review diff

[0m[0m[?7h[0;38;5;178ma//home/b/Projects/freshfind-marketmap/src/lib/api.test.ts → b//home/b/Projects/freshfind-marketmap/src/lib/api.test.ts[0m

[0m[0m[?7h[0;38;5;102m@@ -0,0 +1,245 @@[0m

[0m[0m[?7h[0;38;5;231;48;5;22m+import { describe, it, expe

GSD VERIFY phase found no changes after implementation. Worker output: ]11;?\[0m[?7h[0m ┊ review diff [0m[0m[?7h[0;38;5;178ma//home/b/Projects/freshfind-marketmap/src/lib/api.test.ts → b//home/b/Projects/freshfind-marketmap/src/lib/api.test.ts[0m [0m[0m[?7h[0;38;5;102m@@ -0,0 +1,245 @@[0m [0m[0m[?7h[0;38;5;231;48;5;22m+import { describe, it, expe

Mark added

blocked:needs-decision

and removed

blocked:needs-human

labels

2026-05-27 20:32:50 +00:00

Mark commented

2026-05-28 06:00:34 +00:00

Author

Owner

⏸ Needs Decision

Blocking factors:

Didn't meet auto-approve criteria — scope=medium, risk=low, spec=partial

Scope: medium Risk: low Spec: partial Type: enhancement
Summary: Increase test coverage from 11.8% (2/17 files) to >=50% by adding Vitest + React Testing Library tests for the 15 untested source files
Suggestion: Start with utility lib files (lib/random.ts, lib/utils.ts, lib/api.ts) — pure logic, highest ROI — then hooks and co-located component tests. Vitest, jsdom, and @testing-library/react are already configured in package.json and vite.config.ts; no new dependencies needed. Co-locate .test.tsx files next to their source modules following the existing Navigation.test.tsx pattern.
Rationale: Scope is medium: ~7-9 files need tests to reach the 50% target, a meaningful but bounded effort with the test framework already wired up. Risk is low: purely additive work — no production code paths are changed. Spec alignment is partial: no explicit testing mandate in the project spec, but test scripts exist in package.json and the vitest config is fully set up, so test infrastructure is clearly intended. Type is enhancement: this improves code quality/confidence without adding features or fixing bugs.

Action: Review each blocking factor above. Remove blocked:needs-decision label to route back to triage.

## ⏸ Needs Decision **Blocking factors:** - **Didn't meet auto-approve criteria** — scope=medium, risk=low, spec=partial --- **Scope:** medium **Risk:** low **Spec:** partial **Type:** enhancement **Summary:** Increase test coverage from 11.8% (2/17 files) to >=50% by adding Vitest + React Testing Library tests for the 15 untested source files **Suggestion:** Start with utility lib files (lib/random.ts, lib/utils.ts, lib/api.ts) — pure logic, highest ROI — then hooks and co-located component tests. Vitest, jsdom, and @testing-library/react are already configured in package.json and vite.config.ts; no new dependencies needed. Co-locate .test.tsx files next to their source modules following the existing Navigation.test.tsx pattern. **Rationale:** Scope is medium: ~7-9 files need tests to reach the 50% target, a meaningful but bounded effort with the test framework already wired up. Risk is low: purely additive work — no production code paths are changed. Spec alignment is partial: no explicit testing mandate in the project spec, but test scripts exist in package.json and the vitest config is fully set up, so test infrastructure is clearly intended. Type is enhancement: this improves code quality/confidence without adding features or fixing bugs. **Action:** Review each blocking factor above. Remove `blocked:needs-decision` label to route back to triage.

Mark added

triage-approved

quickfix

and removed

blocked:needs-decision

labels

2026-05-28 07:18:46 +00:00

Mark commented

2026-06-01 19:15:56 +00:00

Author

Owner

🤖 [quickfix-freshfind-marketmap-8] still working — overseer retry