EmbroideryPipeline.stages dict is never populated — no way to introspect pipeline progress #35
Labels
No labels
blocked:children
blocked:depends-101
blocked:depends-103
blocked:depends-104
blocked:needs-attention
blocked:needs-decision
blocked:no-changes
blocked:preflight
bug
chore
feature-request
in-progress
lint-cleanup
needs-decompose
performance
quality
quickfix
security/medium
triage-approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Mark/easystitch#35
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Bug
EmbroideryPipeline.__init__()constructs the four orchestrator components(
raster_converter,semantic_analyzer,dom_resolver,physical_optimizer)but never populates
self.stageswith thePipelineStageinstances. ThePipelineStageobjects are created lazily insideprocess()and neverattached to the pipeline.
Reproduction
After a
process()call,p.stagesis still{}because the localPipelineStageinstances are never assigned toself.stages[...].Impact
87ms, ..." timings back to the client.
scratch.
Fix
In
process(), after creating eachPipelineStage, register it:self.stages[stage.name] = stage.Also fix the docstring on
__init__to documentself.stagesas apublicly-readable dict.
Acceptance
process()returns,p.stagesis a dict with one entry per stage.name,description,start_time,end_time,duration./v1/digitizeresponse includes astagesbreakdown.Cross-link: ThreadCraft #11 — stage timings in /v1/digitize response depend on this fix.