test_files/ tests fail to collect — reference non-existent generate_stitches function #12

New issue

Closed

opened 2026-05-14 13:57:05 +00:00 by Mark · 1 comment

Mark commented

2026-05-14 13:57:05 +00:00

Owner

Bug

Running pytest fails during collection with 4 import errors. The test files in test_files/ reference a function generate_stitches that doesn't exist in src.embroidery_converter.stitch_generator. The real function is named convert_to_stitches.

Evidence

ERROR test_files/test_artifact_generation.py
ERROR test_files/test_dst_generator.py
ERROR test_files/test_integration.py
ERROR test_files/test_stitch_generator.py

All with:

ImportError: cannot import name 'generate_stitches' from 'src.embroidery_converter.stitch_generator'

Additional config issue

The pytest config in pyproject.toml has:

[tool.pytest.ini_options]
testpaths = ["easystitch/tests"]

This path doesn't exist. The actual test directories are tests/ and test_files/. The 3 tests in tests/test_main.py pass fine.

Severity

RED Critical — The test suite is broken. 4/4 test files in test_files/ are completely non-functional. Regression detection is compromised.

Fix

Rename generate_stitches to convert_to_stitches in imports, OR rename convert_to_stitches to generate_stitches in stitch_generator.py and update all callers
Fix pytest testpaths config

## Bug Running `pytest` fails during collection with 4 import errors. The test files in `test_files/` reference a function `generate_stitches` that doesn't exist in `src.embroidery_converter.stitch_generator`. The real function is named `convert_to_stitches`. ## Evidence ``` ERROR test_files/test_artifact_generation.py ERROR test_files/test_dst_generator.py ERROR test_files/test_integration.py ERROR test_files/test_stitch_generator.py ``` All with: ``` ImportError: cannot import name 'generate_stitches' from 'src.embroidery_converter.stitch_generator' ``` ## Additional config issue The pytest config in `pyproject.toml` has: ```toml [tool.pytest.ini_options] testpaths = ["easystitch/tests"] ``` This path doesn't exist. The actual test directories are `tests/` and `test_files/`. The 3 tests in `tests/test_main.py` pass fine. ## Severity RED **Critical** — The test suite is broken. 4/4 test files in `test_files/` are completely non-functional. Regression detection is compromised. ## Fix - Rename `generate_stitches` to `convert_to_stitches` in imports, OR rename `convert_to_stitches` to `generate_stitches` in stitch_generator.py and update all callers - Fix pytest testpaths config