tests: test_digitize_settings_affect_output is vacuous (passes even if settings have no effect) #6
Labels
No labels
blocked:needs-attention
blocked:needs-decision
bug
feature-request
in-progress
needs-decompose
quickfix
triage-approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Mark/easystitch-service#6
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
tests/unit/test_endpoints.py::test_digitize_settings_affect_output claims different settings yield different bodies but only asserts the response key sets are equal, so it passes even when min_stitch_length_mm has no effect on the digitize output. Fix: assert a concrete output difference for the two settings configs (e.g. stitch count or regions differ), or drop the test. Verification:
pytest tests/unit/test_endpoints.py -k settings_affect.