Mark/docker_backup
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

Replace mock API layer with real backend integration #1

New issue
Closed
opened 2026-03-21 21:13:22 +00:00 by Mark · 21 comments
Mark commented 2026-03-21 21:13:22 +00:00
Owner
Copy link

Description

Replace the mock API layer in src/lib/api.ts with real HTTP calls to a backend server.

Current State

  • All API functions use mock data with simulated delays
  • Functions return hardcoded mock data from mockData.ts
  • No actual network requests are made

Required Changes

  1. Create API client with proper error handling
  2. Replace mock data returns with fetch/axios calls
  3. Add authentication headers (JWT tokens)
  4. Implement proper error handling with { data, error } tuples
  5. Add request/response type definitions
  6. Handle network errors gracefully

Files Affected

  • src/lib/api.ts (entire file)
  • May need: src/lib/client.ts (new API client)

Acceptance Criteria

  • All API functions call real backend endpoints
  • Authentication is properly handled
  • Errors return as { data, error } tuples
  • Loading states work correctly
## Description Replace the mock API layer in `src/lib/api.ts` with real HTTP calls to a backend server. ## Current State - All API functions use mock data with simulated delays - Functions return hardcoded mock data from `mockData.ts` - No actual network requests are made ## Required Changes 1. Create API client with proper error handling 2. Replace mock data returns with `fetch`/`axios` calls 3. Add authentication headers (JWT tokens) 4. Implement proper error handling with `{ data, error }` tuples 5. Add request/response type definitions 6. Handle network errors gracefully ## Files Affected - `src/lib/api.ts` (entire file) - May need: `src/lib/client.ts` (new API client) ## Acceptance Criteria - [ ] All API functions call real backend endpoints - [ ] Authentication is properly handled - [ ] Errors return as `{ data, error }` tuples - [ ] Loading states work correctly
Mark commented 2026-05-18 12:12:12 +00:00
Author
Owner
Copy link

Feature Triage Assessment

Scope: small
Risk: low
Spec Alignment: misaligned
Summary: Issue requests replacing a mock API layer with real backend calls, but this work was already completed — api.ts already makes real HTTP requests via client.ts and does not use mock data.
Recommendation: Close as already done. The real API integration is fully in place: client.ts handles JWT auth, fetch, interceptors, and error throwing (per spec), while api.ts provides typed domain APIs (volumesApi, targetsApi, etc.) with context-aware error wrapping. The only cleanup opportunity is removing the dead mockData.ts + its test file, since nothing imports them.
Rationale: SCOPE=small: Issue's premise is already implemented — api.ts (459 lines) calls real endpoints through client.ts, not mock data. RISK=low: existing code is well-structured, tested (client.test.ts has 245 lines of vitest coverage), and stores already use real APIs. SPEC=misaligned: (1) Issue asks for { data, error } tuples, but AGENTS.md explicitly says 'API functions throw errors on failure (not { data, error } tuples)' — current code correctly throws. (2) Issue says 'May need: src/lib/client.ts (new API client)' — it already exists with interceptor pipeline, auth, and tests. (3) Issue describes mock delays/hardcoded returns, but api.ts has zero imports from mockData.ts and never simulates delays. The issue appears to have been filed against an older revision and never closed.

Labeled blocked:needs-decision — unblock on Forgejo to dispatch to the fixer pipeline.

## Feature Triage Assessment **Scope:** small **Risk:** low **Spec Alignment:** misaligned **Summary:** Issue requests replacing a mock API layer with real backend calls, but this work was already completed — `api.ts` already makes real HTTP requests via `client.ts` and does not use mock data. **Recommendation:** Close as already done. The real API integration is fully in place: `client.ts` handles JWT auth, fetch, interceptors, and error throwing (per spec), while `api.ts` provides typed domain APIs (`volumesApi`, `targetsApi`, etc.) with context-aware error wrapping. The only cleanup opportunity is removing the dead `mockData.ts` + its test file, since nothing imports them. **Rationale:** SCOPE=small: Issue's premise is already implemented — `api.ts` (459 lines) calls real endpoints through `client.ts`, not mock data. RISK=low: existing code is well-structured, tested (client.test.ts has 245 lines of vitest coverage), and stores already use real APIs. SPEC=misaligned: (1) Issue asks for `{ data, error }` tuples, but AGENTS.md explicitly says 'API functions throw errors on failure (not { data, error } tuples)' — current code correctly throws. (2) Issue says 'May need: src/lib/client.ts (new API client)' — it already exists with interceptor pipeline, auth, and tests. (3) Issue describes mock delays/hardcoded returns, but api.ts has zero imports from mockData.ts and never simulates delays. The issue appears to have been filed against an older revision and never closed. Labeled `blocked:needs-decision` — unblock on Forgejo to dispatch to the fixer pipeline.
Mark commented 2026-05-26 21:25:50 +00:00
Author
Owner
Copy link

Note: #2 (Docker daemon integration for volume discovery) is a sub-task within this issue's scope — closing as duplicate.

Note: #2 (Docker daemon integration for volume discovery) is a sub-task within this issue's scope — closing as duplicate.
Mark commented 2026-05-27 21:26:48 +00:00
Author
Owner
Copy link

🤖 Claimed by gsd-issue-fixer-docker_backup-1 — starting work

🤖 Claimed by `gsd-issue-fixer-docker_backup-1` — starting work
Mark commented 2026-05-27 21:26:48 +00:00
Author
Owner
Copy link

🤖 Claimed by gsd-issue-fixer-docker_backup-1 — starting work

🤖 Claimed by `gsd-issue-fixer-docker_backup-1` — starting work
Mark commented 2026-05-27 21:26:48 +00:00
Author
Owner
Copy link

🤖 Claimed by gsd-issue-fixer-docker_backup-1 — starting work

🤖 Claimed by `gsd-issue-fixer-docker_backup-1` — starting work
Mark commented 2026-05-27 21:26:48 +00:00
Author
Owner
Copy link

🤖 [gsd-issue-fixer-docker_backup-1] still working — claimed — starting pipeline

🤖 [`gsd-issue-fixer-docker_backup-1`] still working — claimed — starting pipeline
Mark commented 2026-05-27 21:26:48 +00:00
Author
Owner
Copy link

🤖 Claimed by gsd-issue-fixer-docker_backup-1 — starting work

🤖 Claimed by `gsd-issue-fixer-docker_backup-1` — starting work
Mark commented 2026-05-27 21:26:48 +00:00
Author
Owner
Copy link

🤖 [gsd-issue-fixer-docker_backup-1] still working — claimed — starting pipeline

🤖 [`gsd-issue-fixer-docker_backup-1`] still working — claimed — starting pipeline
Mark commented 2026-05-27 21:26:49 +00:00
Author
Owner
Copy link

🤖 [gsd-issue-fixer-docker_backup-1] still working — claimed — starting pipeline

🤖 [`gsd-issue-fixer-docker_backup-1`] still working — claimed — starting pipeline
Mark commented 2026-05-27 21:26:49 +00:00
Author
Owner
Copy link

🤖 [gsd-issue-fixer-docker_backup-1] still working — claimed — starting pipeline

🤖 [`gsd-issue-fixer-docker_backup-1`] still working — claimed — starting pipeline
Mark commented 2026-05-27 21:26:49 +00:00
Author
Owner
Copy link

🤖 [gsd-issue-fixer-docker_backup-1] still working — research

🤖 [`gsd-issue-fixer-docker_backup-1`] still working — research
Mark commented 2026-05-27 21:26:49 +00:00
Author
Owner
Copy link

🤖 [gsd-issue-fixer-docker_backup-1] still working — research

🤖 [`gsd-issue-fixer-docker_backup-1`] still working — research
Mark commented 2026-05-27 21:26:49 +00:00
Author
Owner
Copy link

🤖 [gsd-issue-fixer-docker_backup-1] still working — research

🤖 [`gsd-issue-fixer-docker_backup-1`] still working — research
Mark commented 2026-05-27 21:26:49 +00:00
Author
Owner
Copy link

GSD pipeline blocked at RESEARCH: prerequisite gate (fetch) not passed.
Pipeline state needs reset. Check if another run is in progress.

GSD pipeline blocked at RESEARCH: prerequisite gate (fetch) not passed. Pipeline state needs reset. Check if another run is in progress.
Mark commented 2026-05-27 21:27:00 +00:00
Author
Owner
Copy link

🤖 [gsd-issue-fixer-docker_backup-1] still working — plan

🤖 [`gsd-issue-fixer-docker_backup-1`] still working — plan
Mark commented 2026-05-27 21:27:00 +00:00
Author
Owner
Copy link

🤖 [gsd-issue-fixer-docker_backup-1] still working — plan

🤖 [`gsd-issue-fixer-docker_backup-1`] still working — plan
Mark commented 2026-05-27 21:27:21 +00:00
Author
Owner
Copy link

🤖 [gsd-issue-fixer-docker_backup-1] still working — implement attempt 1

🤖 [`gsd-issue-fixer-docker_backup-1`] still working — implement attempt 1
Mark commented 2026-05-27 21:27:21 +00:00
Author
Owner
Copy link

🤖 [gsd-issue-fixer-docker_backup-1] still working — implement attempt 1

🤖 [`gsd-issue-fixer-docker_backup-1`] still working — implement attempt 1
Mark commented 2026-05-27 21:27:34 +00:00
Author
Owner
Copy link

🤖 [gsd-issue-fixer-docker_backup-1] still working — plan

🤖 [`gsd-issue-fixer-docker_backup-1`] still working — plan
Mark commented 2026-05-27 21:28:56 +00:00
Author
Owner
Copy link

🤖 [gsd-issue-fixer-docker_backup-1] still working — implement attempt 1

🤖 [`gsd-issue-fixer-docker_backup-1`] still working — implement attempt 1
Mark commented 2026-05-27 21:29:32 +00:00
Author
Owner
Copy link

Fixed in commit. Closing.

Fixed in commit. Closing.
Mark closed this issue 2026-05-27 21:29:32 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
No results found.
Labels
Clear labels   
blocked:gate-fetch

   
blocked:gate-fetch

   
blocked:gate-fetch

   
blocked:gate-fetch

   
blocked:lint-failed

   
blocked:needs-decision

   
blocked:no-changes

   
blocked:no-procedure

   
blocked:verify-failed

   
bug

Something is not working correctly

  
feature-request

   
in-progress

   
needs-decompose

Ready to be decomposed into sub-issues

  
needs-triage

   
ops-task

Operations task — install, configure, deploy, API calls

  
quickfix

   
security/high

High severity security issue

  
security/low

Low severity security issue

  
security/medium

Medium severity security issue

  
test-coverage

Test coverage review / gap report

  
triage-approved

Approved by triage pipeline

No labels
blocked:gate-fetch
blocked:gate-fetch
blocked:gate-fetch
blocked:gate-fetch
blocked:lint-failed
blocked:needs-decision
blocked:no-changes
blocked:no-procedure
blocked:verify-failed
bug
feature-request
in-progress
needs-decompose
needs-triage
ops-task
quickfix
security/high
security/low
security/medium
test-coverage
triage-approved
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Mark/docker_backup#1
No description provided.