Webhook notifications never fire: session events don't call dispatch_event #42

New issue

Closed

opened 2026-08-14 03:28:22 +00:00 by Mark · 0 comments

Mark commented

2026-08-14 03:28:22 +00:00

Owner

Reproduction:

Create a webhook subscription via POST /webhooks.
Create, start, stop, then delete a session via the API.
Observe webhook_deliveries: no rows are ever created; the subscriber receives nothing.

Expected: session lifecycle events (session.created, session.started, session.stopped, session.deleted) fire dispatch_event after the DB commit and each configured webhook receives a delivery, per plans/issue-17-plan.md.
Actual: no event is ever dispatched. The feature's stated use cases ("Notify Slack when session is created/stopped", "Trigger CI/CD pipeline") are unimplemented.

Kanban card: t_223849fd (probe finding 1, follow-up to closed Mark/devforge#17).

Webhook CRUD routes exist (services/api/app/routes/webhooks.py) and tests pass, but the core use case is dead: dispatch_event in services/api/app/services/webhooks.py has zero production callers. Repo-wide, dispatch_event appears only in the service definition and in tests. main.py's create_session / start_session / stop_session / delete_session handlers contain no webhook references. Reproduction: 1. Create a webhook subscription via POST /webhooks. 2. Create, start, stop, then delete a session via the API. 3. Observe webhook_deliveries: no rows are ever created; the subscriber receives nothing. Expected: session lifecycle events (session.created, session.started, session.stopped, session.deleted) fire dispatch_event after the DB commit and each configured webhook receives a delivery, per plans/issue-17-plan.md. Actual: no event is ever dispatched. The feature's stated use cases ("Notify Slack when session is created/stopped", "Trigger CI/CD pipeline") are unimplemented. Kanban card: t_223849fd (probe finding 1, follow-up to closed Mark/devforge#17).