Black Ichor damage invisible to player: applied outside resolution effect chain #63

New issue

Closed

opened 2026-09-15 04:49:09 +00:00 by Mark · 0 comments

Mark commented

2026-09-15 04:49:09 +00:00

Owner

Summary

In resolver.ts, Black Ichor's damage is applied to workingState.players AFTER lastTurnResult is built and stored. The resolution overlay (CasualDuel.tsx) iterates selfEffects/opponentEffects to display what happened — Black Ichor damage doesn't appear there, so the player sees the vitality drop without explanation.

Where

src/engine/resolver.ts: processBlackIchor call site (around line 734)
src/engine/reactiveConditions.ts: processBlackIchor function

Repro

Player has Black Ichor condition (cast by opponent)
Opponent completes a damage spell this turn
Vitality drops by 1 per Black Ichor stack, but the resolution overlay shows the spell as the only source of damage

Why this matters

Players can't reason about cause and effect in damage
Black Ichor's effect becomes a hidden tax with no UI signal

Acceptance criteria

Black Ichor damage events appear in selfEffects/opponentEffects so the overlay renders them
OR: a separate Black Ichor overlay event is rendered alongside the spell resolution
OR: Black Ichor damage is folded into the parent spell's damage at resolution time

## Summary In resolver.ts, Black Ichor's damage is applied to workingState.players AFTER lastTurnResult is built and stored. The resolution overlay (CasualDuel.tsx) iterates selfEffects/opponentEffects to display what happened — Black Ichor damage doesn't appear there, so the player sees the vitality drop without explanation. ## Where - src/engine/resolver.ts: processBlackIchor call site (around line 734) - src/engine/reactiveConditions.ts: processBlackIchor function ## Repro 1. Player has Black Ichor condition (cast by opponent) 2. Opponent completes a damage spell this turn 3. Vitality drops by 1 per Black Ichor stack, but the resolution overlay shows the spell as the only source of damage ## Why this matters - Players can't reason about cause and effect in damage - Black Ichor's effect becomes a hidden tax with no UI signal ## Acceptance criteria - Black Ichor damage events appear in selfEffects/opponentEffects so the overlay renders them - OR: a separate Black Ichor overlay event is rendered alongside the spell resolution - OR: Black Ichor damage is folded into the parent spell's damage at resolution time