Dead enum value: CounterType 'phase-disrupt' has no counter implementation #61

New issue

Closed

opened 2026-09-15 04:49:08 +00:00 by Mark · 0 comments

Mark commented

2026-09-15 04:49:08 +00:00

Owner

Summary

The CounterType union (src/engine/types.ts) declares 'phase-disrupt', but COUNTER_DEFINITIONS in src/engine/counters.ts contains no counter of that type. The 'modifyEffectsByCounter' case for phase-disrupt returns []. Either implement a counter using this type or remove it from the union.

Where

src/engine/types.ts: CounterType union (line 168-179)
src/engine/counters.ts: COUNTER_DEFINITIONS (no phase-disrupt entry)

Why this matters

Dead types mislead readers about what the system actually supports
If phase-disrupt is intended as a feature, its absence is a missing capability
If phase-disrupt is leftover scaffolding, it adds cognitive overhead

Acceptance criteria

Either:

Add a counter definition using counterType: 'phase-disrupt' with appropriate conditions and effect, OR
Remove 'phase-disrupt' from the CounterType union and the case in modifyEffectsByCounter.

## Summary The CounterType union (src/engine/types.ts) declares 'phase-disrupt', but COUNTER_DEFINITIONS in src/engine/counters.ts contains no counter of that type. The 'modifyEffectsByCounter' case for phase-disrupt returns []. Either implement a counter using this type or remove it from the union. ## Where - src/engine/types.ts: CounterType union (line 168-179) - src/engine/counters.ts: COUNTER_DEFINITIONS (no phase-disrupt entry) ## Why this matters - Dead types mislead readers about what the system actually supports - If phase-disrupt is intended as a feature, its absence is a missing capability - If phase-disrupt is leftover scaffolding, it adds cognitive overhead ## Acceptance criteria Either: 1. Add a counter definition using counterType: 'phase-disrupt' with appropriate conditions and effect, OR 2. Remove 'phase-disrupt' from the CounterType union and the case in modifyEffectsByCounter.