Mark/chainbound

CI tsc step swallows type errors with '|| true' #57

New issue

Closed

opened 2026-08-11 19:06:27 +00:00 by Mark · 0 comments

Mark commented

2026-08-11 19:06:27 +00:00

Owner

In .forgejo/workflows/ci.yml the step npx tsc --noEmit 2>&1 || true never fails the build — the || true discards all type errors. The subsequent npm run build does run tsc -b so type errors are caught there eventually, but the explicit tsc check is dead code and gives a false sense of coverage. Remove the || true so the step actually enforces types.

In .forgejo/workflows/ci.yml the step `npx tsc --noEmit 2>&1 || true` never fails the build — the `|| true` discards all type errors. The subsequent `npm run build` does run `tsc -b` so type errors are caught there eventually, but the explicit tsc check is dead code and gives a false sense of coverage. Remove the `|| true` so the step actually enforces types.

Mark added the

triage-approved

labels

2026-08-13 00:13:12 +00:00

Mark

2026-08-14 00:33:08 +00:00

closed this issue
removed the
triage-approved
label

Mark referenced this issue from a commit

2026-08-14 00:33:08 +00:00

revert(ci): restore || true masking for atomic #57 fix commit

Mark referenced this issue from a commit

2026-08-14 00:33:08 +00:00

fix #57: enforce tsc type check in CI (remove || true masking)

Mark referenced this issue from a commit

2026-08-14 00:33:08 +00:00

Apply changes from kilo-gsd.py run for Mark/chainbound#57

Mark referenced this issue

2026-08-14 06:33:17 +00:00

CI tsc step still a no-op after #57 fix: solution-style tsconfig makes npx tsc --noEmit typecheck 0 files #58

Sign in to join this conversation.

No labels

blocked:lint-failed

blocked:needs-decision

blocked:no-changes

feature-request

triage-approved

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Mark/chainbound#57

No description provided.