Fix the lint on animsuite #25

New issue

Closed

opened 2026-08-10 19:18:57 +00:00 by Mark · 1 comment

Mark commented

2026-08-10 19:18:57 +00:00

Owner

Pre-flight lint check for Mark/animsuite failed. Kilo-GSD is hard-gated on clean lint and refuses to start work on this repo until the debt is resolved.

What is dirty

invalid-syntax: Unexpected indentation
    --> animbuild/render/render_shot.py:1123:1
     |
1121 |         resolved_commands.append(resolved_cmd)
1122 |     path_asset = {"shape": "path", "commands": resolved_commands}
1123 |             if drawable.get("closed") is not None:
     | ^^^^^^^^^^^^
1124 |                 path_asset["closed"] = drawable["closed"]
1125 |             fill_data = drawable.get("fill")
     |

invalid-syntax: unindent does not match any outer indentation level
    --> animbuild/render/render_shot.py:1152:1
     |
1150 |             cv.restore()
1151 |
1152 |         def draw_prop(drawable, anim_local, prop_states, actor_states):
     | ^^^^^^^^
1153 |             asset_id = drawable.get("asset") or drawable.get("prop")
1154 |             asset_data = None
     |

invalid-syntax: Unexpected indentation
    --> animbuild/render/render_shot.py:1216:1
     |
1214 |                 asset_data["stroke"] = stroke_data
1215 |         param_defs = asset_data.get("param_defs")
1216 |                 merged_params = {}
     | ^^^^^^^^^^^^^^^^
1217 |                 if isinstance(param_defs, dict):
1218 |                     for key, definition in param_defs.items():
     |

invalid-syntax: unindent does not match any outer indentation level
    --> animbuild/render/render_shot.py:1246:13
     |
1244 |                             merged_sprite["frame"] = int(round(sample_scalar(frame_track, f)))
1245 |                     asset_data["sprite"] = merged_sprite
124

Why this issue exists

Kilo-GSD was attempting Mark/animsuite#8 but the preflight ruff check . returned 1. We do not knowingly pass along lint errors; the original ticket is held until this one is resolved and the lint is clean.

Scope

Fix every lint error reported above so ruff check . exits 0 against Mark/animsuite. Do not change behavior — only fix style/dead-code/safety issues that lint flags. Commit on a branch and open a PR. Once merged, kilo-gsd will resume the held tickets.

Pre-flight lint check for `Mark/animsuite` failed. Kilo-GSD is hard-gated on clean lint and refuses to start work on this repo until the debt is resolved. ## What is dirty ``` invalid-syntax: Unexpected indentation --> animbuild/render/render_shot.py:1123:1 | 1121 | resolved_commands.append(resolved_cmd) 1122 | path_asset = {"shape": "path", "commands": resolved_commands} 1123 | if drawable.get("closed") is not None: | ^^^^^^^^^^^^ 1124 | path_asset["closed"] = drawable["closed"] 1125 | fill_data = drawable.get("fill") | invalid-syntax: unindent does not match any outer indentation level --> animbuild/render/render_shot.py:1152:1 | 1150 | cv.restore() 1151 | 1152 | def draw_prop(drawable, anim_local, prop_states, actor_states): | ^^^^^^^^ 1153 | asset_id = drawable.get("asset") or drawable.get("prop") 1154 | asset_data = None | invalid-syntax: Unexpected indentation --> animbuild/render/render_shot.py:1216:1 | 1214 | asset_data["stroke"] = stroke_data 1215 | param_defs = asset_data.get("param_defs") 1216 | merged_params = {} | ^^^^^^^^^^^^^^^^ 1217 | if isinstance(param_defs, dict): 1218 | for key, definition in param_defs.items(): | invalid-syntax: unindent does not match any outer indentation level --> animbuild/render/render_shot.py:1246:13 | 1244 | merged_sprite["frame"] = int(round(sample_scalar(frame_track, f))) 1245 | asset_data["sprite"] = merged_sprite 124 ``` ## Why this issue exists Kilo-GSD was attempting `Mark/animsuite#8` but the preflight `ruff check .` returned 1. We do not knowingly pass along lint errors; the original ticket is held until this one is resolved and the lint is clean. ## Scope Fix every lint error reported above so `ruff check .` exits 0 against `Mark/animsuite`. Do not change behavior — only fix style/dead-code/safety issues that lint flags. Commit on a branch and open a PR. Once merged, kilo-gsd will resume the held tickets.

Mark referenced this issue from a commit

2026-08-12 09:12:44 +00:00

fix(lint): repair indentation in render_shot.py so ruff check . exits 0 (#25)

Mark commented

2026-08-12 09:12:59 +00:00

Author

Owner

ruff check . now exits 0 on the tracked tree. Root cause was broken indentation in animbuild/render/render_shot.py (introduced in 4e4074e7, the #19 Path/Curve implementation): two code blocks were dedented 8 spaces, cascading into 6 invalid-syntax errors. Repaired indentation only (git diff -w is empty) in 3f0a9c3. Lint baseline is clean — closing cleanup issue.

`ruff check .` now exits 0 on the tracked tree. Root cause was broken indentation in `animbuild/render/render_shot.py` (introduced in 4e4074e7, the #19 Path/Curve implementation): two code blocks were dedented 8 spaces, cascading into 6 invalid-syntax errors. Repaired indentation only (git diff -w is empty) in 3f0a9c3. Lint baseline is clean — closing cleanup issue.

Mark closed this issue

2026-08-12 09:13:05 +00:00