Bug: Settings and Help icon buttons in AppHeader have no onClick handler — clicking is a no-op #52

New issue

Closed

opened 2026-09-01 16:52:08 +00:00 by Mark · 0 comments

Mark commented

2026-09-01 16:52:08 +00:00

Owner

Summary

The icon buttons in AppHeader.tsx for Settings and Help are styled as interactive buttons (title="Settings", <Settings size={16}/> icon, hover background) but have no onClick handler. Clicking either button is a no-op. Same for the small generic [ref=e7] upload logo at the very left of the header — also cursor=pointer but no handler.

This makes two of the three always-visible buttons in the top-right of the Workspace decorative — they look like controls, they aren't.

Steps to Reproduce

Visit http://127.0.0.1:5173/workspace
Click the Settings cog in the top-right (next to Export PES).
Click the ? Help icon to its right.

Expected

Either:

A panel/modal opens (Settings), or a help dialog opens, or
The button is removed/disabled if there's no implementation yet — but its current state (looks active, no behavior) is misleading.

Actual

Nothing happens. act click ref=e9 (Settings) returns ok (click) and --- Additional context: no change since last snapshot — same for Help and the upload logo.

Affected Buttons

From /home/b/Projects/Kimi_Agent_Brother_10_Digitizing_App/src/components/workspace/AppHeader.tsx:

Settings cog (lines 128-136) — title="Settings", no onClick
Help ? (lines 137-145) — title="Help", no onClick
(Possibly the small generic at the top-left, ref=e7, also lacks an onClick — header logo to upload?)

Compare with the working Export PES button (lines ~120-126) which does onClick={onExport} and correctly opens the modal.

Severity

Medium. Visible UI debt that reaches every Workspace page load — every user sees a Settings icon and Help icon they reasonably expect to function.

Suggested Fix

Pick one:

Wire onClick to dispatch a SET_SETTINGS_DIALOG_OPEN state and render a SettingsDialog (mirroring ExportDialog), plus a SET_HELP_DIALOG_OPEN.
Hide/remove the buttons until the panels are implemented (better UX than a dead control).
If they're meant to be available soon, mark them aria-disabled with a tooltip "Coming soon" — at minimum match the visual cue to the behavior.

Shakedown Context

Surfaced on 2026-09-01 during the BB-monogram GUI shakedown. Repro was via the BrowserOS MCP act kind=click on the page-55 workspace snapshot; the click landed (CDP confirmed) but the React handler was missing.

Environment

ThreadCraft frontend on localhost:5173 (Vite dev)
easystitch-service backend on localhost:8080
Branch / commit: HEAD of Kimi_Agent_Brother_10_Digitizing_App repo (unmodified by this shakedown)

## Summary The icon buttons in `AppHeader.tsx` for **Settings** and **Help** are styled as interactive buttons (`title="Settings"`, `<Settings size={16}/>` icon, hover background) but have **no `onClick` handler**. Clicking either button is a no-op. Same for the small `generic [ref=e7]` upload logo at the very left of the header — also `cursor=pointer` but no handler. This makes two of the three always-visible buttons in the top-right of the Workspace **decorative** — they look like controls, they aren't. ## Steps to Reproduce 1. Visit `http://127.0.0.1:5173/workspace` 2. Click the **Settings** cog in the top-right (next to Export PES). 3. Click the **?** Help icon to its right. ## Expected Either: - A panel/modal opens (Settings), or a help dialog opens, or - The button is removed/disabled if there's no implementation yet — but its current state (looks active, no behavior) is misleading. ## Actual Nothing happens. `act click ref=e9` (Settings) returns `ok (click)` and `--- Additional context: no change since last snapshot` — same for Help and the upload logo. ## Affected Buttons From `/home/b/Projects/Kimi_Agent_Brother_10_Digitizing_App/src/components/workspace/AppHeader.tsx`: - **Settings cog** (lines 128-136) — `title="Settings"`, no `onClick` - **Help ?** (lines 137-145) — `title="Help"`, no `onClick` - (Possibly the small generic at the top-left, ref=e7, also lacks an `onClick` — header logo to upload?) Compare with the working **Export PES** button (lines ~120-126) which does `onClick={onExport}` and correctly opens the modal. ## Severity **Medium.** Visible UI debt that reaches every Workspace page load — every user sees a Settings icon and Help icon they reasonably expect to function. ## Suggested Fix Pick one: 1. Wire `onClick` to dispatch a `SET_SETTINGS_DIALOG_OPEN` state and render a `SettingsDialog` (mirroring `ExportDialog`), plus a `SET_HELP_DIALOG_OPEN`. 2. Hide/remove the buttons until the panels are implemented (better UX than a dead control). 3. If they're meant to be available soon, mark them `aria-disabled` with a tooltip "Coming soon" — at minimum match the visual cue to the behavior. ## Shakedown Context Surfaced on 2026-09-01 during the BB-monogram GUI shakedown. Repro was via the BrowserOS MCP `act kind=click` on the page-55 workspace snapshot; the click landed (CDP confirmed) but the React handler was missing. ## Environment - ThreadCraft frontend on `localhost:5173` (Vite dev) - easystitch-service backend on `localhost:8080` - Branch / commit: HEAD of `Kimi_Agent_Brother_10_Digitizing_App` repo (unmodified by this shakedown)