Export dialog hardcodes "Brother PR-10 thread stop" text even when user has customized library post-#120 — text doesn't reflect the live catalog #155

New issue

Closed

opened 2026-10-03 16:05:50 +00:00 by Mark · 1 comment

Mark commented

2026-10-03 16:05:50 +00:00

Owner

Finding

The Export dialog (src/components/workspace/ExportDialog.tsx:295-298) renders thread-stop count text with a hardcoded "Brother PR-10 thread stop" label:

<span className="text-[13px]" style={{ color: '#6B6560' }}>
  This design uses {threadStops.length} Brother PR-10 thread stop{threadStops.length !== 1 ? 's' : ''}
</span>

This text is wrong in two ways:

It says "Brother PR-10" even when the user has customized their thread library (post #120). If the user has 5 custom colors from a Madeira or Coats & Clark palette, the dialog still says "Brother PR-10 thread stops." That's misleading.
It's pluralized with "stops" which is embroidery jargon; a more descriptive label would be "thread colors" or "thread changes" (a "stop" is a single thread-change point in the stitch sequence; the count shown is the number of distinct colors).

Where

src/components/workspace/ExportDialog.tsx:295-298

Suggested fix shape

Replace the hardcoded text with a more accurate label. Two options:

Generic "thread colors" wording that doesn't claim a specific brand: "This design uses {N} thread color{s}."
Show the source of the colors: when the user's library has been customized past the default PR-10 set, show "Custom palette" or "User library" instead. Keep "Brother PR-10" only when the library matches the default.

The pluralization also benefits from a terminology review: in embroidery, a "thread stop" is a thread change in the stitch sequence (one per color), not a "color" per se. "Thread colors" is the user-facing term; "thread stops" is the technical term. The current text confuses them.

Severity

Low. Cosmetic. The text is wrong but not breaking; users will still understand what it means.

Discovered by

Gap analysis (2026-10-02) of export dialog.

#120 (closed) — replaced the hardcoded library with a CRUD library. The Export dialog's hardcoded "Brother PR-10" text was not updated to reflect this.

## Finding The Export dialog (`src/components/workspace/ExportDialog.tsx:295-298`) renders thread-stop count text with a hardcoded "Brother PR-10 thread stop" label: ```tsx <span className="text-[13px]" style={{ color: '#6B6560' }}> This design uses {threadStops.length} Brother PR-10 thread stop{threadStops.length !== 1 ? 's' : ''} </span> ``` This text is wrong in two ways: 1. **It says "Brother PR-10" even when the user has customized their thread library** (post #120). If the user has 5 custom colors from a Madeira or Coats & Clark palette, the dialog still says "Brother PR-10 thread stops." That's misleading. 2. **It's pluralized with "stops"** which is embroidery jargon; a more descriptive label would be "thread colors" or "thread changes" (a "stop" is a single thread-change point in the stitch sequence; the count shown is the number of distinct colors). ## Where `src/components/workspace/ExportDialog.tsx:295-298` ## Suggested fix shape Replace the hardcoded text with a more accurate label. Two options: 1. **Generic "thread colors" wording** that doesn't claim a specific brand: "This design uses {N} thread color{s}." 2. **Show the source of the colors**: when the user's library has been customized past the default PR-10 set, show "Custom palette" or "User library" instead. Keep "Brother PR-10" only when the library matches the default. The pluralization also benefits from a terminology review: in embroidery, a "thread stop" is a thread change in the stitch sequence (one per color), not a "color" per se. "Thread colors" is the user-facing term; "thread stops" is the technical term. The current text confuses them. ## Severity Low. Cosmetic. The text is wrong but not breaking; users will still understand what it means. ## Discovered by Gap analysis (2026-10-02) of export dialog. ## Related - #120 (closed) — replaced the hardcoded library with a CRUD library. The Export dialog's hardcoded "Brother PR-10" text was not updated to reflect this.

Mark added the

bug

triage-approved

labels

2026-10-03 16:05:51 +00:00

Mark referenced this issue from a commit

2026-10-03 17:03:21 +00:00

fix(#155): Export dialog no longer hardcodes 'Brother PR-10 thread stops'

Mark commented

2026-10-03 17:03:28 +00:00

Author

Owner

Fixed in commit e50d468 on main. The Export dialog now picks a label from the live catalog source:

Brother PR-10 thread colors when the live catalog is from the Brother PR-10 service (#120)
Custom palette thread colors when the user has overridden the library
thread colors as a generic fallback

Also corrected the terminology: a thread stop is the embroidery-jargon term for a color-change point, but the count shown to users is the number of distinct thread colors. The dialog now says thread color{s} consistently.

Closing this issue. Thanks for the careful gap analysis.

— triage-runner

Fixed in commit e50d468 on main. The Export dialog now picks a label from the live catalog source: - **Brother PR-10 thread colors** when the live catalog is from the Brother PR-10 service (#120) - **Custom palette thread colors** when the user has overridden the library - **thread colors** as a generic fallback Also corrected the terminology: a *thread stop* is the embroidery-jargon term for a color-change point, but the count shown to users is the number of distinct *thread colors*. The dialog now says `thread color{s}` consistently. Closing this issue. Thanks for the careful gap analysis. — triage-runner

Mark closed this issue

2026-10-03 17:03:31 +00:00